creativetimofficial / now-ui-kit

Now UI Kit Bootstrap 4 - Designed by Invision. Coded by Creative Tim
https://www.creative-tim.com/product/now-ui-kit
Other
1.7k stars 376 forks source link

[Bug] Native checkbox validation fails #105

Open stebogit opened 4 years ago

stebogit commented 4 years ago

Version

1.3

Reproduction link

https://jsfiddle.net/jStefano/j23nvhy0

Operating System

MAC OS

Device

MacBook

Browser & Version

Chrome/Firefox

Steps to reproduce

input a username and don't check the checkbox, then hit submit

What is expected?

the browser form validation should display a warning prompting the user to check the terms and conditions checkbox

What is actually happening?

the warning is not shown, in fact nothing happens, and in Chrome an error is logged to the console


Solution

remove visibility: hidden from the input style and move it a bit so that the warning message can appear in the expected position.

.form-check input[type="checkbox"] {
    opacity: 0;
    position: absolute;
    visibility: initial !important;
    left: 27px;
    top: 8px;
}

Additional comments

dragosct commented 4 years ago

Hi, @stebogit! Thanks for using our products. Did you mean that the style is not present when the checkbox is not selected and you press the submit button, right?

Regards, Dragos

stebogit commented 4 years ago

@dragosct10 no the issue is the warning message not showing:

Screen Shot 2020-08-20 at 8 20 57 AM

and this the error you get, only on Chrome, if you have visibility: hidden on the input

Screen Shot 2020-08-20 at 9 30 46 AM

dragosct commented 4 years ago

Hi! Now I get it. The solution is good the visibility hidden must be removed.

Regards, Dragos