creativetimofficial / vue-argon-dashboard

Vue Argon Dashboard
https://demos.creative-tim.com/vue-argon-dashboard
MIT License
379 stars 724 forks source link

bulid: use official @googlemaps/js-api-loader #58

Closed jpoehnelt closed 3 years ago

jpoehnelt commented 3 years ago

Use the official dynamic loading package for Google Maps JS. See https://developers.google.com/maps/documentation/javascript/overview#js_api_loader_package.

dragosct commented 3 years ago

Hi, @jpoehnelt! Thanks for using our products and for this PR. Please can you tell us which improvements will give us this change?

Regards, Dragos

jpoehnelt commented 3 years ago

This is the official package used for dynamically loading the Google Maps JS API. While it is still open source and community supported, it is officially maintained by my team(Google Maps Platform Developer Relations).

The benefits over the other package are:

dragosct commented 3 years ago

@jpoehnelt! Thanks for your explication. We will check it and merge the PR.

Regards, Dragos

rarestoma commented 3 years ago

Hi @jpoehnelt,

I tested now your PR and there are the following errors in the src/views/Maps.vue file.

 102:28  error    'google' is not defined  no-undef
 152:23  error    'google' is not defined  no-undef
 156:26  error    'google' is not defined  no-undef

Thank you, Rares

jpoehnelt commented 3 years ago

I added google to the eslint globals.

rarestoma commented 3 years ago

Hi @jpoehnelt,

It is working now, I will merge your PR.

Thank you, Rares