search

credativ / informix_fdw

Foreign Data Wrapper for Informix Databases
Other
28 stars 5 forks source link

Build Error after latest commit - support for postgresql 13 #29

Closed jocasta closed 2 years ago

jocasta commented 3 years ago

Hi

I'd just like to report a build error after the latest commit - support for postgresql 13 (July 2020) - We reverted to a previous cloned repo and the build was successful. Thought I'd post the error here for awareness.

[root@es-vrli-pgrd65 informix_fdw-master]# INFORMIXDIR=/opt/IBM/Informix_Client-SDK/ USE_PGXS=1 make install gcc -std=gnu99 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fPIC -I/opt/IBM/Informix_Client-SDK//incl/esql -I. -I./ -I/usr/pgsql-12/include/server -I/usr /pgsql-12/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include -c -o ifx_conv.o ifx_conv.c

ifx_conv.c: In function ‘ifx_predicate_tree_walker’: ifx_conv.c:2731:46: error: macro "lnext" passed 2 arguments, but takes just 1 if (PG_LIST_NEXT_ITEM(boolexpr->args, cell) != NULL) ^ In file included from ifx_conv.c:45:0: ifx_fdw.h:66:33: error: ‘lnext’ undeclared (first use in this function); did you mean ‘text’?

define PG_LIST_NEXT_ITEM(l, c) lnext((l), (c))

                             ^

ifx_conv.c:2731:8: note: in expansion of macro ‘PG_LIST_NEXT_ITEM’ if (PG_LIST_NEXT_ITEM(boolexpr->args, cell) != NULL) ^~~~~ ifx_fdw.h:66:33: note: each undeclared identifier is reported only once for each function it appears in

define PG_LIST_NEXT_ITEM(l, c) lnext((l), (c))

                             ^

ifx_conv.c:2731:8: note: in expansion of macro ‘PG_LIST_NEXT_ITEM’ if (PG_LIST_NEXT_ITEM(boolexpr->args, cell) != NULL) ^~~~~ make: *** [: ifx_conv.o] Error 1

psoo commented 3 years ago

Oh yes, sorry, this was my fault. I managed to mess up the PG13 version checks for specific includes and function signatures, i apologize. Not sure what i had in mind with this. See commit 145dae2853c820fb9016a3c97e1f104a37d6c510, i would be glad if you can verify that everything works now.

psoo commented 2 years ago

Seems to work, so i close this issue