credbull / credbull-defi

Credbull main repository. Includes our EVM smart contracts, services and tests.
https://credbull.io/
MIT License
6 stars 1 forks source link

For CI, deploy to Arbitrum Sepolia instead of Base Sepolia #89

Open jplodge-pro opened 1 month ago

jplodge-pro commented 1 month ago

Deploy to Arbitrum Sepolia testnet instead of Base Sepolia, for CI deployments.

Done

Resolves https://github.com/credbull/credbull-defi/issues/88

jplodge-pro commented 1 month ago

Thanks for the review, @lucasia

the deployment to arbitrumSepolia from the branch works fine using the below on my machine at lest. please confirm the versions of forge and forge-std you are using.

forge nightly (foundryup) forge 0.2.0 (4351742 2024-08-07T00:24:31.137910000Z)

  • foundryup
  • forge --version

git submodule status 07263d193d621c4b2b0ce8b4d54af58f6957d97d forge-std (v1.9.1) dbb6104ce834628e473d2173bbc9d47f81a9eec3 openzeppelin-contracts (v5.0.0-12-gdbb6104c)

I foolishly ran foundryup before checking my version, so I don't know my previous version. Now, however, my versions are as follows:

forge 0.2.0 (7f0f5b4 2024-08-08T00:19:27.650028841Z)
 07263d193d621c4b2b0ce8b4d54af58f6957d97d lib/forge-std (v1.9.1)
 dbb6104ce834628e473d2173bbc9d47f81a9eec3 lib/openzeppelin-contracts (v5.0.0-12-gdbb6104c)

I will re-test the deployment.

UPDATE

The problem was that I did not have ETHERSCAN_API_KEY AND ARBITRUM_SEPOLIA_ETHERSCAN_API_KEY set in the .env file at the same time. With that setting, the deploy/verify works correctly (db-export still fails, as that supabase instance is mothballed).

openzeppelin-code[bot] commented 1 month ago

For CI, deploy to Arbitrum Sepolia instead of Base Sepolia

Generated at commit: dce2a85d1f69710b1156314b13fef4b300b41160

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
4
15
19
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector