search

credential-handler / authn.io

Credential Mediator Polyfill
https://github.com/w3c-ccg/credential-handler-api
Other
44 stars 8 forks source link

Turn on "Remember my choice" by default #99

Closed JSAssassin closed 3 years ago

JSAssassin commented 3 years ago

@dlongley I've updated the code to set rememberChoice to true when canceled is true and when reset() is called. I have a question though, should the behavior when the cancel button is clicked be the same as when the back arrow button is clicked? Right now when a cancel button is clicked and then we start the CHAPI flow again, it automatically selects the previously selected option while the back button shows the CHAPI dialogue box with options to choose and the Remember my choice turned on.

dlongley commented 3 years ago

@JSAssassin,

I have a question though, should the behavior when the cancel button is clicked be the same as when the back arrow button is clicked? Right now when a cancel button is clicked and then we start the CHAPI flow again, it automatically selects the previously selected option while the back button shows the CHAPI dialogue box with options to choose and the Remember my choice turned on.

What do you think would be the best UX?

JSAssassin commented 3 years ago

@dlongley I think giving the user the options to choose again after they cancel would be the best UX. What do you think? Should I go ahead and make that change?

dlongley commented 3 years ago

@JSAssassin,

I think giving the user the options to choose again after they cancel would be the best UX. What do you think? Should I go ahead and make that change?

Yes, I agree -- you should make the change. Thanks!