search

credential-handler / credential-handler-polyfill

Credential Handler API polyfill
https://chapi.io
BSD 3-Clause "New" or "Revised" License
36 stars 13 forks source link

1Password extension conflicts with `navigator.credentials.get` #38

Open brianorwhatever opened 1 year ago

brianorwhatever commented 1 year ago

Starting around version 2.14.0 the 1Password extension is capturing all of the get requests and not passing them onto other scripts such as CHAPI. This is likely bad behaviour on their behalf..

msporny commented 7 months ago

We are starting to hear from more people in the field that are hitting this issue. We really need to push a fix to detect and re-patch (or something equivalent). Let's get back in touch w/ the 1Password folks to see what their plans are to ensure this doesn't happen in future releases... and in parallel, ship code to detect and fix (if possible) the issue .

Custard7 commented 3 months ago

We just started seeing errors related to the Credential Management API: CHAPI is breaking for us when the browser already has navigator.credentials.get()

https://developer.mozilla.org/en-US/docs/Web/API/CredentialsContainer/get

Have y'all started to run into this?

dlongley commented 3 months ago

Yes, #42 is the proposed fix for this -- we just need to do some more testing and then deploy it. cc: @jameseaster

jameseaster commented 3 months ago

I've tested #42 and it looks good to go!

davidlehn commented 3 months ago

3.2.1 was released with the update. Please test in various environments. If no further reports come in, this can be closed.