New first responder badge credential for medical technician

credential-handler / vc-examples

Verifiable Credentials for the CHAPI Playground

BSD 3-Clause "New" or "Revised" License

4 stars 5 forks source link

New first responder badge credential for medical technician #49

Closed jameseaster closed 4 months ago

jameseaster commented 4 months ago

Resolves - adds new first responder badge credential for medical technician

What kind of change does this PR introduce?

New VC example for first responder badge.

What is the current behavior?

No current FR EMT badge credential.

What is the new behavior?

FR EMT badge credential.

NOTE: This uses the examples context instead of the appropriate context, because VC v2 and renderMethod are not yet stable.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

How has this been tested?

Locally rendered, issued, and verified.

Screenshots: n/a

jameseaster commented 4 months ago

@BigBlueHat Medical Technician SVG is looking great here! A few notes:

I'm seeing we are using 3 different FR blue star logos: Without words, with words in a circle (the iconography, and with horizontal words on issuer's image
SVG needs rounded boarders to mimic a card
SVG needs a background color as it currently blends into the UI background

You also noted:

font issues
Utopia background

jameseaster commented 4 months ago

For reference:

SVG with values

BigBlueHat commented 4 months ago

I'm seeing we are using 3 different FR blue star logos: Without words, with words in a circle (the iconography, and with horizontal words on issuer's image

Not quite sure how to resolve these... One is the icon image.png used on the VC Playground, so I could drop the words there (as I expect they'll be illegible). The other one standalone image is for the issuer...so not keen to change their colors...and not keen to match that blue either. Any preference here, @jameseaster?

BigBlueHat commented 4 months ago

SVG needs rounded boarders to mimic a card

Not sure we need to do this one. The ecosystem will certainly do both (at various points). I can if you want me to, but I think it'll depend on the designer of the SVG in the future and since these sort of simulate "random" credentials...maybe it's fine? 😁 Let me know if you really want that changed.

BigBlueHat commented 4 months ago

All other issues should be addressed.

jameseaster commented 4 months ago

@BigBlueHat

One is the icon image.png used on the VC Playground, so I could drop the words there (as I expect they'll be illegible).

Let's match these, I'll remove the words from the image.png file.

jameseaster commented 4 months ago

Rendered locally and looks awesome! Thanks @BigBlueHat