search

credentials / irma_mobile

IRMA app for iOS and Android
Apache License 2.0
25 stars 11 forks source link

Request: clientReturnUrl or similar also in QR workflow #118

Open Wassasin opened 4 years ago

Wassasin commented 4 years ago

The clientReturnUrl functionality is designed to work in the mobile-only flow. It however is not intended to work when starting the session on a separate machine and using the QR-code flow.

For my current use case I am interested in using the clientReturnUrl or something similar to initialize an Irma session on a computer or tablet, disclose using a phone, and subsequently to start calling a phonenumber with the tel:+123456 scheme.

I am able to submit a merge request for this, as soon as a decision can be made concerning the desirability and proper interface for this change.

confiks commented 4 years ago

Support for this is actually already present in irma_mobile, but currently disabled. If you uncomment this line, the tel: scheme will be recognized and a different UI will be rendered.

This logic ensures that the clientReturnUrl will also be used for QR-started sessions.

Wassasin commented 4 years ago

Do you intend to enable it? For my usecase during our development-phase we could run with a custom build of IRMA mobile, but that would be very inconvenient when we proceed to user trials.

confiks commented 4 years ago

We want to reach feature parity in the new app, so we only want to enable it in the old app if we're sure, one way or another, that its going to be supported in the new app.