Signing with unknown attribute crashes app

credentials / irma_mobile

IRMA app for iOS and Android

Apache License 2.0

25 stars 11 forks source link

Signing with unknown attribute crashes app #74

Closed stevenvegt closed 5 years ago

stevenvegt commented 5 years ago

To reproduce: Construct a contract with an attribute which the user does not have Scan the QR The app crashes without error.

Details: OS: iOS App version: 5.5.3 (35)

davidv1992 commented 5 years ago

Sorry for the late response.

Which attribute did you use to test this? I can't seem to reproduce this on both the version you mention, nor on the current version of the app.

stevenvegt commented 5 years ago

To be honest, I don't really know anymore. If you've tested it with unknown attributes in a signing session like you said, than it is probably fixed, or my bug report is invalid. If you like you can close this one.

davidv1992 commented 5 years ago

What do you mean with unknown? I have tested it with attributes that the app was aware of of existing (i.e. attributes that were in the apps scheme), but just didn't have an instance of. Do you mean you changed something to the scheme only on the irma server producing the request? So that the attribute did not occur in the scheme as known by the app?

sietseringers commented 5 years ago

The problem was, I think, that before condiscon was released:

the irma server did not properly check if the requested attributes exist in the scheme, it just passed them on to the app;
the app would crash on such nonexisting attributes.

Both of them now check existence of the attributes in the scheme before doing anything, so this should be fixed now.