credija / opa

Opa - A modern XMPP Chat Client for the Web
MIT License
83 stars 14 forks source link

XMPP presence priority #38

Open Neustradamus opened 5 years ago

Neustradamus commented 5 years ago

Can you add the XMPP presence priority? from -128 to +127.

kevinfaveri commented 5 years ago

You mean when sending the presence stanzas? I could turn this into a parameter, like the URL parameter of the XMPP server.

Neustradamus commented 5 years ago

From here: https://tools.ietf.org/html/rfc6121#section-4.7.2.3

kevinfaveri commented 5 years ago

From here: https://tools.ietf.org/html/rfc6121#section-4.7.2.3

Yeah it is sending the priority prop on presence stanzas... will look into a solution for this...

kevinfaveri commented 5 years ago

XMPP presence priority now defaults to +127

Neustradamus commented 5 years ago

Why have you selected directly the max value by default?

It is possible to select manually in the webchat? The user must select a value only between -128 and +127.

kevinfaveri commented 5 years ago

I'm going to need to think about it better, but I do not think of leaving it configurable by the user as it will add more settings and the idea of Opa is not to support everything, but to be a simple web client for XMPP. If I can find a way that looks cool in the user experience I will add this functionality.

My concern is with the user experience, but as I intend to remake part of the UI in the future, I might add a configuration for priority...

So, I'm going to open this issue as I decide whether this request will be met in some way or whether the priority tag will be omitted (where 0 is assumed).

Opa is currently omitting the priority tag (so 0 should be assumed by XMPP specs).