search

creditkarma / thrift-server

Thrift core library in TypeScript
Apache License 2.0
40 stars 15 forks source link

thrift-client-ttwitter-filter: ttwitter classes not in package #108

Open jlai opened 5 years ago

jlai commented 5 years ago

Trying to use the ttwitter filter gives this error:

Error: Cannot find module '../ttwitter/com/creditkarma/finagle/thrift'

Probably because the files list in package.json only has dist/main and not dist/ttwitter

ramakrishna-battala-ck commented 5 years ago

Hi @jlai, Can I get how ttwitter filter is being used in your use case.

jlai commented 5 years ago

Using it as documented in the readme, e.g.

import {ThriftClientTTwitterFilter} from '@creditkarma/thrift-client-ttwitter-filter';

and connection.register(ThriftClientTTwitterFilter(filterOptions))

It's a packaging issue. Fixing it should be as simple as adding dist/ttwitter to https://github.com/creditkarma/thrift-server/blob/master/packages/thrift-client-ttwitter-filter/package.json

niodice commented 5 days ago

Added a PR with that suggestion here - https://github.com/creditkarma/thrift-server/pull/197