search

creditkarma / thrift-typescript

Generate TypeScript from Thrift IDL files
Apache License 2.0
155 stars 32 forks source link

fix imported identifiers in maps #174

Open hayes opened 5 years ago

hayes commented 5 years ago

fixes #173

Currently when resolving const values, identifiers are not resolved recursively, so if identifiers nested inside other ast nodes (eg maps) are used, the may not have been transformed correctly, which breaks referencing types in other files in these cases.

hayes commented 5 years ago

@kevin-greene-ck could you take a look at this when you have a chance?

niodice commented 1 year ago

cc @kevin-greene-ck (tagging you since you seem to be the most active contributor). Do you think this is something suitable for merging? I am also hitting this issue as a blocker for adopting this package for thrift file compilation.