creditkey / magento2-b2bgateway

Credit Key Magento 2 Module
MIT License
0 stars 4 forks source link

Cleanup for M2 Standards #16

Closed rain2o closed 5 years ago

rain2o commented 5 years ago

I hope you don't mind, I took some time to go through the module using Magento's recommended code sniffer (https://github.com/magento/magento-coding-standard) for their best practices and coding standards and performed some cleanup.

In addition to formatting changes this PR also involves the removal of some classes that didn't appear to be used anywhere, or served no purpose. If they were left there intentionally I can add them back, but I didn't see any purpose that they served.

Additionally I added a central Config helper to be used for getting all config field values to provide an easier and cleaner solution when needing to access these values throughout the module.

I tested this as thoroughly as I could locally but I would suggest a complete regression test to ensure none of these changes broke any existing functionality.

This should also be merged after PR #15 as this includes the latest updates from that PR.