search

credomane / FactorioMods_FactorioMaps

Jeroon's Factorio Maps mod
http://www.factorioforums.com/14582
47 stars 7 forks source link

Feature Request - GMaps API key as configuration #8

Closed warmfusion closed 7 years ago

warmfusion commented 7 years ago

Rather than having to hand-wrangle the index.html each time I export the map, can I provide the API key as part of the Advanced Configuration (and for it to persist) such that when the index is written out the key is automatically included?

dbartholomae commented 7 years ago

As far as my experiments go, you just need to copy the image directory and keep the old index.html :)

credomane commented 7 years ago

Adding this feature through the new mod settings GUI as a per-user setting. That should allow you to set your key once and use is in every game! I'm liking these new mod settings in 0.15.

credomane commented 7 years ago

Noticed a bug with the new mod setting GUI. Please change the mod setting from the main menu only with NO game loaded. If you change the setting while a save is loaded then setting it isn't saved at all. I'm making a test mod show-casing the issue and will file a big report with Factorio devs in a little while.

Leaving this open until I hear back from the devs on a resolution.

[edit]
I made a goof and pulled the mod setting incorrectly. The in-game mod setting menu still shows the wrong config value but the settings actually are changed. This is a Factorio bug hopefully the devs will get it fixed.