search

creecros / Group_assign

Kanboard Plugin to Assign Tasks to Groups and multiple users
MIT License
62 stars 24 forks source link

Error when filtering #48

Closed Jandalf81 closed 5 years ago

Jandalf81 commented 5 years ago

Hi there,

we are in the process of installing KanBoard. It works great so far, we just think we found a bug.

First, here's some information of our system:

Everything works, we can create new cards and assign more users and groups as designed. But then we get an error when we try to filter for the assigned group: Internal Error: SQL Error: SQLSTATE[22P02]: Invalid text representation: 7 FEHLER: ungültige Eingabesyntax für ganze Zahl: »« LINE 1: ...group_has_users WHERE group_has_users.user_id IN ('')) OR ta... ^ See errorlog.txt for more details.

I think the error is produced around line 102 in Filter/TaskAllAssigneeFilter.php. The variable $useridstring seems to be empty which in turn invalidates the whole SQL statement. I don't know why, though.

Is there anything you need from us to find this bug?

creecros commented 5 years ago

Tell me exactly what you are putting in the search field.

Jandalf81 commented 5 years ago

Thank you for taking the time to help me. Unfortunately, I will not be able to answer this question until monday. The Kanboard installation is at work and I can't reach it from home... ;-(

If I remember right, we did the following:

Something I forgot to mention is that we have another test installation which works as expected. The only differences (to my knowledge) are

Since we are talking about using KanBoard with a lot of existing users at work, we obviously want to use both LDAP and PostgreSQL...

creecros commented 5 years ago

I duplicated and will look into it: Internal Error: SQL Error: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: "" LINE 1: ...group_has_users WHERE group_has_users.user_id IN ('')) OR ta... ^

creecros commented 5 years ago

updating line 97 to: $useridstring = intval(implode("','", $useridsarray));

solves it, just want to run more tests and make sure it doesn't break anything on various setups.

Jandalf81 commented 5 years ago

I can confirm that this fix at least doesn't break my SQLite installation. I have to wait for my admin to test the PostgreSQL installation, though...

Jandalf81 commented 5 years ago

Today I can also confirm that this fixed the problem with our PostgreSQL installation. We haven't found new bugs but didn't test extensively, yet

creecros commented 5 years ago

Thanks for testing for me, I'll update the release next chance I get.

Jandalf81 commented 5 years ago

I want to thank you for your fast help! I'll close this bug now as it seems to be resolved. We'll install the next "official" update as soon as it's ready.