search

creecros / Group_assign

Kanboard Plugin to Assign Tasks to Groups and multiple users
MIT License
62 stars 24 forks source link

name parameter according to input #64

Closed Chaosmeister closed 3 years ago

Chaosmeister commented 3 years ago

php 8 supports named parameters

the very last part is about backwards-compatibility with call_user_func_array, so it might be necessary to change it in kanboard base accordingly.

image

The changes in this PR also fix the error as the name now equals the name from the array.

creecros commented 3 years ago

this is good to merge? I can't test currently, so just making sure.

Chaosmeister commented 3 years ago

it runs without errors on my testing instance with PHP 8.0.10

Chaosmeister commented 3 years ago

I also proposed the change in kanboard base

Chaosmeister commented 3 years ago

the changes in kanboard base were merged. this mergerequest may be omitted.