search

creecros / MarkdownPlus

Improved Markdown, with check boxes, emoji shortcode, inline html, etc...
MIT License
52 stars 15 forks source link

PHP-Warning Messages for invalid Checkbox-Markdown #5

Closed wakka90 closed 1 year ago

wakka90 commented 2 years ago

Hi,

thanks for the great Plugin! :) we are using the latest Kanboard Version 1.2.22 and the latest Plugin for MarkdownPlus installed via PluginManager in Kanboard.

The following example will throw a Warning-Message in Kanboard:

grafik

The Warning would be displayed anywhere in Kanboard (Description, Comments, etc.) where the error occurs.

We created a Merge Request like this one (https://github.com/creecros/MarkdownPlus/commit/bcff4903f288252fa9562c79ba519f454ac1ab0d) for a quickfix.

Regards.

Chaosmeister commented 2 years ago

hey, thanks for the report!

what does the description look like to create the error case?

wakka90 commented 2 years ago

Hi, here are the entries for the Description. Using the space will make a difference for checkboxes and will throw the warning message as seen in the screenshot above.

[]Test Failure

[ ] Test OK

Chaosmeister commented 2 years ago

I can't reproduce this behaviour on my instance:

image

image

what configuration does your server have?

wakka90 commented 2 years ago

This is our configuration:

grafik

Chaosmeister commented 2 years ago

ah might be a php 8 thing then. I'll merge your fix

thanks again for reporting!