creeperyang / id3-parser

A pure JavaScript id3 tag parser.
54 stars 13 forks source link

add non-polyfilled entrypoint #14

Closed mad-gooze closed 7 years ago

mad-gooze commented 7 years ago

This PR propses several changes:

  1. In environments with polyfilled or native Promise support there is no need to bundle promise-a-plus. This PR adds a new entrypoint id3-parser/lib/parser-non-polyfilled.js without promise-a-plus included.
  2. Polluting global Buffer, File and FileReader can break stuff, so they should not be replace with noop.
creeperyang commented 7 years ago

LGTM.

mad-gooze commented 7 years ago

Could you merge and publish a release if everything is ok please?