creepyjim / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
0 stars 0 forks source link

fix a too strict test for selected organization in loguserpass template #420

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
See issue 419

When the organization is presetted, the template doesn't apply it correctly 
because of a too strict test.

Correction patch attached

Original issue reported on code.google.com by josselin...@gmail.com on 2 Aug 2011 at 3:38

Attachments:

GoogleCodeExporter commented 8 years ago
Actually, the organization IDs are expected to be strings. (The 
getOrganizations()-function is expected to return an «Associative array with 
the organizations».) The test works if that is the case.

I am not sure if that is something that we want to change - the code was 
written with strings in mind, and changing it to also allow integers would 
require changing more than just that test.

Original comment by olavmrk@gmail.com on 3 Aug 2011 at 5:55

GoogleCodeExporter commented 8 years ago
Well during my tests, it just works with int, appart from this test.

Original comment by josselin...@gmail.com on 7 Aug 2011 at 1:30

GoogleCodeExporter commented 8 years ago
The UserPassOrgBase also handles different cases, e.g. where you don't have an 
dropdown-list, but the user instead enters <username>@<realm>, where realm is a 
string from the array index.

Original comment by olavmrk@gmail.com on 9 Aug 2011 at 8:03

GoogleCodeExporter commented 8 years ago
Closing this issue as WontFix. It was designed to deal with strings.

Original comment by olavmrk@gmail.com on 26 Feb 2014 at 12:28