creepyjim / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
0 stars 0 forks source link

private casValidation in sspmod_cas_Auth_Source_CAS #423

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The casValidation method is called from the public method finalStep. When you 
want to make Inheritance in order to change the way attributes are mastered, 
you just neep to reimplement finalStep.
But because of this private casValidation method, you have to copy paste 
casValidation and other method that are called inside casValidation.

Is it possible to use protected for this method ?

Included patch (one line change)

Original issue reported on code.google.com by josselin...@gmail.com on 8 Aug 2011 at 1:37

Attachments:

GoogleCodeExporter commented 8 years ago
Sure - I see no problems changing it to protected. I have applied your patch as 
r2886.

Original comment by olavmrk@gmail.com on 9 Aug 2011 at 8:13

GoogleCodeExporter commented 8 years ago
Thanks

Original comment by josselin...@gmail.com on 9 Aug 2011 at 8:34