creepyjim / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
0 stars 0 forks source link

Make SimpleSAMLSessionID cookie name configurable #426

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
In relation to issue 413 and as suggested by simon in the third comment it 
would be great if the name of the 'SimpleSAMLSessionID'-cookie can be 
configured as well.

A patch against the current head is attached.

Original issue reported on code.google.com by daniel.b...@ymc.ch on 10 Aug 2011 at 3:48

Attachments:

GoogleCodeExporter commented 8 years ago
I have a couple of changes I would like to see before committing this:

- To keep the name of the option in line with the other settings, could it be 
named something like 'session.cookie.name' instead?

- Could you also add the option to config-templates/config.php with a short 
comment describing it?

Original comment by olavmrk@gmail.com on 10 Aug 2011 at 8:24

GoogleCodeExporter commented 8 years ago
This is already in progress with patch in issue 418.

Original comment by comel...@gmail.com on 10 Aug 2011 at 8:50

GoogleCodeExporter commented 8 years ago
Great to here that this issue already has been addressed. Anyhow I already 
updated my patch and attached it to this issue. The option to configure the 
cookie now is 'session.cookie.name', just like in issue #418.

One might set this issue here as a duplicate of #418...

Original comment by daniel.b...@ymc.ch on 10 Aug 2011 at 9:11

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by comel...@gmail.com on 10 Aug 2011 at 12:20