creesch / discordIRCd

A node.js script that allows you to connect to discord with your irc client.
Apache License 2.0
115 stars 21 forks source link

Username mention in DM crashes discordIRCd server #39

Open devtea opened 6 years ago

devtea commented 6 years ago

When your discord nick is mentioned in a direct message, the discordIRCd server will crash. The issue seems to be 100% reproducable any time the other person in the DM mentions you.

/home/devtea/discordircd/server.js:132
            const memberObject = discordClient.guilds.get(discordID).members.get(userID);
                                                                    ^

TypeError: Cannot read property 'members' of undefined
    at /home/devtea/discordircd/server.js:132:69
    at Array.forEach (<anonymous>)
    at parseDiscordLine (/home/devtea/discordircd/server.js:130:26)
    at /home/devtea/discordircd/server.js:909:40
    at Array.forEach (<anonymous>)
    at /home/devtea/discordircd/server.js:906:24
    at Array.forEach (<anonymous>)
    at Client.<anonymous> (/home/devtea/discordircd/server.js:895:22)
    at Client.emit (events.js:159:13)
    at MessageCreateHandler.handle (/home/devtea/discordircd/node_modules/discord.js/src/client/websocket/packets/handlers/MessageCreate.js:9:34)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! discord-ircd@0.5.0 start: `node server.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the discord-ircd@0.5.0 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/devtea/.npm/_logs/2017-12-29T15_53_25_883Z-debug.log

Contents of /home/devtea/.npm/_logs/2017-12-29T15_53_25_883Z-debug.log

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'start' ]
2 info using npm@5.6.0
3 info using node@v9.3.0
4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle discord-ircd@0.5.0~prestart: discord-ircd@0.5.0
6 info lifecycle discord-ircd@0.5.0~start: discord-ircd@0.5.0
7 verbose lifecycle discord-ircd@0.5.0~start: unsafe-perm in lifecycle true
8 verbose lifecycle discord-ircd@0.5.0~start: PATH: /usr/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/devtea/discordircd/node_modules/.bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin:/usr/local/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/home/devtea/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/home/devtea/bin
9 verbose lifecycle discord-ircd@0.5.0~start: CWD: /home/devtea/discordircd
10 silly lifecycle discord-ircd@0.5.0~start: Args: [ '-c', 'node server.js' ]
11 silly lifecycle discord-ircd@0.5.0~start: Returned: code: 1  signal: null
12 info lifecycle discord-ircd@0.5.0~start: Failed to exec start script
13 verbose stack Error: discord-ircd@0.5.0 start: `node server.js`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:285:16)
13 verbose stack     at EventEmitter.emit (events.js:159:13)
13 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:159:13)
13 verbose stack     at maybeClose (internal/child_process.js:943:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:220:5)
14 verbose pkgid discord-ircd@0.5.0
15 verbose cwd /home/devtea/discordircd
16 verbose Linux 4.14.8-1-ARCH
17 verbose argv "/usr/bin/node" "/usr/bin/npm" "start"
18 verbose node v9.3.0
19 verbose npm  v5.6.0
20 error code ELIFECYCLE
21 error errno 1
22 error discord-ircd@0.5.0 start: `node server.js`
22 error Exit status 1
23 error Failed at the discord-ircd@0.5.0 start script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]