search

creesch / discordIRCd

A node.js script that allows you to connect to discord with your irc client.
Apache License 2.0
115 stars 21 forks source link

WIP: Modularize project #53

Open SkyLeite opened 5 years ago

SkyLeite commented 5 years ago

This is an initial proposal of a better structure for the project, as proposed in #51.

src/services/discord.ts - Class that interacts with the Discord client src/services/irc.ts - Class for the IRC server. Still a lot of TODOs, listed in todo.org util/SocketEx.ts - A wrapper that promisifies net.Socket's asynchronous methods for proper usage util/parseMessage.ts - Message parsing stuff

I also took the liberty of using Typescript, which I believe makes the development process incredibly more comfortable, especially when messing with runtime data types.

I apologize in advance for the bad commit messages. My work is usually all over the place so I never know what to say :p

creesch commented 5 years ago

I had a quick look over and so far it looks good to me. The way you are implementing classes makes sense and should make things easier to maintain.

I don't usually use typescript in my projects but also don't have any objections to it.

I don't know if I will have time to do a proper full review in the near future (as you might have noticed by activity on the project I haven't exactly had a lot of time). I'll see if I can get some other people that use the project to chip in.

SkyLeite commented 5 years ago

There's still quite a bit to be done, so no rush :)

Chew commented 3 years ago

Any progress on this?

thatsprettygood commented 2 years ago

It's dead.

SkyLeite commented 2 years ago

Sorry folks, I don't think I'll be working on this anymore. If anyone is inclined, feel free to fork and continue the work :)