search

creichert / ido-vertical-mode.el

makes ido-mode display vertically
211 stars 22 forks source link

Broken on latest emacs 27 branch #48

Closed wyuenho closed 4 years ago

wyuenho commented 4 years ago

Commit in question: https://github.com/emacs-mirror/emacs/commit/3b0938c0420de2b845e7e8f8fbbb57ddc61718f2

Problems: prompt missing, and the completions left is not inserted after the current selection

oscarfv commented 4 years ago

Have you informed about this to the emacs developers?

wyuenho commented 4 years ago

No, but I don't think the completion display has ever been a public interface anyway. If this brilliant hack of a package is to survive emacs 27, it would be nice if we could find a way forward in this package.

On Fri, Jan 31, 2020 at 11:28 PM oscarfv notifications@github.com wrote:

Have you informed about this to the emacs developers?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/creichert/ido-vertical-mode.el/issues/48?email_source=notifications&email_token=AABHCHEA7DJWK6G3TJGSHOTRASX2DA5CNFSM4KOO5KAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQKXVI#issuecomment-580955093, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABHCHCBU54ZXH6DX2IBJBTRASX2DANCNFSM4KOO5KAA .

oscarfv commented 4 years ago

Probably checking for the symbol ido--overlay and removing the overlay would do.

In the meantime, ido-grid-mode seems unaffected by the change and it has an ido-grid-mode-max-columns parameter.

wyuenho commented 4 years ago

Probably checking for the symbol ido--overlay and removing the overlay would do.

That doesn't work. The overlay is added to the positioned completion list returned from ido-vertical-completions.

Ido-grid-* 's author hasn't answered on github for 4 years, and the new implementation isn't on Melpa and PRs aren't even merged.

Is there anything we can do to ido-vertical-completion to fix this issue for emacs-27?

wyuenho commented 4 years ago

Actually, deleting the overlay just deletes the vertical list altogether.

dgutov commented 4 years ago

What do you mean, no prompt? It's right there, at the top of the minibuffer.

And to put the cursor where it should be, start the completions string with a space:

             (concat
              " "
              ;; put in common completion item -- what you get by pressing tab
wyuenho commented 4 years ago

@dgutov The prompt I mean is the ido-find-file prompt, before emacs-mirror/emacs@3b0938c, it looks like this:

Screen Shot 2020-02-01 at 13 43 30

Now it looks like this:

Screen Shot 2020-02-01 at 14 01 58
nverno commented 4 years ago

Just noticed this as well after recent build. It certainly makes ido-vertical-mode much more confusing to use.

dgutov commented 4 years ago

The prompt I mean is the ido-find-file prompt

OK, now I see that. Couldn't reproduce this part of the problem the previous time I tried. But since Eli might have a fix for that soon-ish, try my suggestion for the cursor problem.

ctrl2wei commented 4 years ago

@dgutov I don't use this package, but how I fix this

emacs -Q
M-x ido-mode
M-: (setq ido-max-window-height 1)

this gets same issue even after 4a0a11

oscarfv commented 4 years ago

@ctrl2wei : please use M-x report-emacs-bug to send your bug report to the Emacs maintainers. Your issue has nothing to do with ido-vertical-mode and belongs to Emacs proper.

dgutov commented 4 years ago

@ctrl2wei @oscarfv I've filed http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39433

wyuenho commented 4 years ago

This appears to have been fixed.