search

creichert / ido-vertical-mode.el

makes ido-mode display vertically
211 stars 22 forks source link

Defcustoms take effect immediately #56

Closed wyuenho closed 3 years ago

wyuenho commented 3 years ago

Please merge #54 first

There's a problem with ido-vertical-indicator right now in that customizing it doesn't update ido-vertical-decorations and in turn ido-decorations until the next restart, not even toggling ido-vertical-mode will update ido-vertical-decorations because once it is defined on first load, it's never updated again. This PR fixes this issue.

This PR also introduces a new option ido-vertical-padding that allows the user to customize the extra whitespace padding on each candidate in case he decides to set ido-vertical-indicator to an empty string.

creichert commented 3 years ago

If you have time to rebase this to get passing checks that would be great. I'll merge it. Thanks!

creichert commented 3 years ago

Thanks! Merging on successful checks

creichert commented 3 years ago

Error I'm seeing on CI for emacs 26 & 27:

0.74s$ cask exec ert-runner
Symbol’s value as variable is void: ido-vertical-padding
The command "cask exec ert-runner" exited with 255.
wyuenho commented 3 years ago

@creichert should be fixed now