creocoder / yii2-flysystem

The Flysystem integration for the Yii framework.
Other
283 stars 76 forks source link

fix Dropbox adapter #50

Closed mikk150 closed 2 years ago

schmunk42 commented 2 years ago

I've never used DropboxAdapter ... did you test these changes with an actual Dropbox-Account?

mikk150 commented 2 years ago

I've never used DropboxAdapter ... did you test these changes with an actual Dropbox-Account?

well, it does not throw an exception.. but I did not get it to work. Dropbox just did not allow me to upload.. I have no idea why

schmunk42 commented 2 years ago

Has the Dropbox library changed this recently? I wonder if we'd need to require a minimum version of the lib.

mikk150 commented 2 years ago

ok, disregard, it does indeed work... I am just doing something stupid here with my tokens. If I took dropbox token from app that has working dropbox connection, it works.

schmunk42 commented 2 years ago

So ready to merge from your side?

mikk150 commented 2 years ago

So ready to merge from your side?

I'm trying to see, if I can maybe use yii2-authclient to get token that actually works

mikk150 commented 2 years ago

and it now works with new token as well.. It was bad UX on Dropbox side.. Cookie policy was blocking submit button....

mikk150 commented 2 years ago

uploading also works #8

mikk150 commented 2 years ago

So ready to merge from your side?

so yes, ready to merge

schmunk42 commented 2 years ago

Thank you!