search

creocoder / yii2-flysystem

The Flysystem integration for the Yii framework.
Other
282 stars 76 forks source link

Upgrade to league/flysystem V3 #60

Open razvanphp opened 2 months ago

razvanphp commented 2 months ago

https://flysystem.thephpleague.com/docs/upgrade-from-1.x/ https://flysystem.thephpleague.com/docs/what-is-new/

Can we do this without breaking everything? Would be nice to keep this extension alive.

I can work on the PR, but a little afraid without unit tests....

Thanks! R

schmunk42 commented 2 months ago

@eluhr @handcode You worked with Flysystem lately, WDYT?

royalrex commented 2 months ago

I'd like to see this happen too - and can help out with a PR.

As I read the code, there is not much to do, other than just update the dependency. All code around flysystem and S3 is external: https://github.com/creocoder/yii2-flysystem/blob/master/src/AwsS3Filesystem.php#L126

This means, that such a package update will be a breaking change. I wonder if it would be an idea to create a small wrapper that maps the old methods to the new (as described in the upgrade guide) and give deprecation warnings when they are used?

schmunk42 commented 2 months ago

@royalrex @razvanphp PRs welcome, we are not very actively developing this extension anymore to be honest.