creode / magic-login

A Magic Link plugin which sits on top of the existing user sign in and registration process.
Other
3 stars 2 forks source link

Create group validation criteria and implement tests for it. #7

Closed jamiesykescreode closed 3 years ago

jamiesykescreode commented 3 years ago

Ben and I discussed some options with user permissions and enforcing the group, described on #8. Ultimately we will leave the check for the Magic Login group but realistically we should think about it being a permission check instead of a group check.

We should also decide on if the Magic Login group is actually a required thing and put in some checks.

jamiesykescreode commented 3 years ago

Comment from Ben:

May be worth informing an admin user in the event that a user group with the MAGIC_LOGIN_USER_GROUP_HANDLE does not exist within the system because it has been deleted. That way, the admin user should be able to manually recreate the group in order to restore default functionality. This may be a change for the next version.