creof / doctrine2-spatial

Doctrine2 multi-platform support for spatial types and functions.
MIT License
272 stars 176 forks source link

Pull request to test value before using function ctype #208

Closed Alexandre-T closed 4 years ago

Alexandre-T commented 4 years ago

This pull request ws created to Fix #207. But when I saw the reports of codeclimat, the problem with travis, I decided to fork the project to purpose a new release of doctrine2-spatial which can works with the current PHP versions and doctrine versions.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-43.0%) to 55.041% when pulling c6e947178cdbf49f777e866083285732593afa92 on Alexandre-T:master into 58ea5fae1c1b450ee08d7dac25cd9e8f5e6fdebd on creof:master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-43.0%) to 55.041% when pulling c6e947178cdbf49f777e866083285732593afa92 on Alexandre-T:master into 58ea5fae1c1b450ee08d7dac25cd9e8f5e6fdebd on creof:master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.4%) to 97.605% when pulling c35c6da6f8da6b127533b1b64a7dc2a4c700e240 on Alexandre-T:master into 58ea5fae1c1b450ee08d7dac25cd9e8f5e6fdebd on creof:master.

holtkamp commented 4 years ago

Great job working on a new fork, also got some change in my fork which might be useful, will have a look after my vacation ;)

Alexandre-T commented 4 years ago

I close this pull request, because my fork will create some BC incompatibility, but i will submit a pull request for a next major version when upgrade will be done.

Alexandre-T commented 4 years ago

Hello @holtkamp , I have published a 2.0.0-rc.0 version. If you want, you can test it and install it via composer (Be careful to specify the 2.0.0-rc.0 version)

composer require "alexandret/doctrine2-spatial:2.0.0-rc.0"

A full documentation can be found here: https://doctrine2-spatial.readthedocs.io/en/latest/

Please forgive me, I'm not fluent in english.

holtkamp commented 4 years ago

Great work @Alexandre-T, will try to have a look coming weeks and report my findings.