search

cresset-template / cresset

Template repository to build PyTorch projects from source on any version of PyTorch/CUDA/cuDNN.
MIT License
715 stars 41 forks source link

Fix PyRe code. #105

Closed veritas9872 closed 1 year ago

veritas9872 commented 1 year ago

https://github.com/cresset-template/cresset/blob/65bf29b33ac72b37da28916c795c420acf9a6c5d/Makefile#L134-L142

This code should be changed to allow it to be run from the host as well. Also create a local pre-commit hook using the Makefile command.

veritas9872 commented 1 year ago

Add the official shellcheck pre-commit too.

veritas9872 commented 1 year ago

Also add hist shortcut for history 1.

veritas9872 commented 1 year ago

Also add a new image for users who can only use trusted Docker images.

veritas9872 commented 1 year ago

On second thoughts, pyre should not be a pre-commit. It has been fixed, though.