cresset-template / cresset

Template repository to build PyTorch projects from source on any version of PyTorch/CUDA/cuDNN.
MIT License
715 stars 41 forks source link

Makefile now actually reads the `.env` file. #109

Closed veritas9872 closed 1 year ago

veritas9872 commented 1 year ago

After testing, I found that the Makefile did not behave as intended. I fixed the bug so that the Makefile does optionally read the .env file. One source of confusion may be that shell variables have higher priority than the .env file for Docker Compose, while the .env variables have higher priority than shell variables for the Makefile. Unfortunately, I could not find a way to fix this issue. Providing Make with variables via the host shell is bad practice anyway, as it breaks hermeticity.