search

creswick / StreamingQR

Apache License 2.0
2 stars 0 forks source link

Settings menu disappears from app #62

Closed lcasburn closed 10 years ago

lcasburn commented 10 years ago

This is the sequence of steps that causes the settings fragment to disappear from the UI in Rx and Tx mode.

  1. Go to settings menu
  2. Push the back button to return to the Rx/Tx window
  3. Try pushing the settings menu again. It does not appear.
donpdonp commented 10 years ago

Related item to fix in this ticket:

donpdonp commented 10 years ago

The problem was MainActivity was taking out the Settings menu option, which is a state that can never add menu options again because the callbacks stop firing for an empty menu.

The fix is to leave the settings menu in, and have the overlay retract even on the settings screen. This fixed the disappearing settings menu, AND the obscured top part of the settings screen.

creswick commented 10 years ago

works for me - can you merge this if it hasn't been yet?

donpdonp commented 10 years ago

merged with master.