GHC-7.6.1 compatibility on Windows 7

creswick / cabal-dev

A wrapper program around cabal and cabal-install that maintains sandboxed build environments.

BSD 3-Clause "New" or "Revised" License

150 stars 24 forks source link

GHC-7.6.1 compatibility on Windows 7 #72

Closed elliottt closed 12 years ago

elliottt commented 12 years ago

This patch includes the following changes:

Expand package ranges to allow ghc-7.6.1 on Windows 7 to build
Update the source to include an import of catch from Control.Exception when ghc-7.6.1 is detected
Remove some unused imports
Upgrade to using tar >= 0.4, as that allows the directory version shipped with ghc-7.6.1 to work. Of all the changes, this is likely to be the most controversial, though I think we can work around it with CPP if it comes to that.

elliottt commented 12 years ago

Looks like there are some other patches in the queue that do just about the same thing as mine. I think that the Win32 changes, and the warning removal are unique, but the rest might be repeated by other pull requests.

RubenAstudillo commented 12 years ago

I like more your aproach. You respect upper-bounds and the CPP trick to catch seems the way to go to handle the different catch functions.

I will use your patches instead of mine :), hope this get merged soon

jtdaugherty commented 12 years ago

After reviewing all of the pull requests for this issue, I'm going to merge this one as it addresses the backwards compatibility issue I cited elsewhere. I think it would be helpful for us to decide on a backwards compatibility policy to make changes like this easier to assess; "always working with the most recent GHC only" is not, IMHO, a viable long-term strategy for this package. Thanks to the others who have put effort into resolving this, and sorry for the delay on getting it merged!