cretueusebiu / valet-windows

Laravel Valet for Windows.
MIT License
912 stars 86 forks source link

Update Ngrok version and Add support for --domain parameter #214

Closed hemant-kr-meena closed 1 year ago

hemant-kr-meena commented 1 year ago

Deprecated --subdomain and --hostname flags in favor of --domain flag which accepts a fully qualified domain.

Read more: Agent CLI and API changes

yCodeTech commented 1 year ago

@hemant-kr-meena I believe this repo is no longer maintained. I am currently developing Laravel Valet Windows 3, so please do go check it out. It tries to achieve as much parity of the Mac version as possible.

In regards to this PR, I have already updated ngrok to v3.3.0 but as of today updated to 3.3.1, also I've changed the share command dramatically so that it no longer has hard-coded parameters but instead it just passes any given commands/options through to ngrok.

For further PRs please submit to my repo, thanks.

@cretueusebiu It might be an idea to add a note on the README saying that this repo isn't maintained, and maybe a link to my repo as an alternative?