search

cretz / pb-and-k

Kotlin Code Generator and Runtime for Protocol Buffers
MIT License
139 stars 15 forks source link

Packed Bool EOF Conformance Test Failure in Latest Protobuf Suite #12

Open cretz opened 5 years ago

cretz commented 5 years ago

Running conformance tests results in the following:

CONFORMANCE TEST BEGIN ====================================

ERROR, test=Required.Proto3.ProtobufInput.PrematureEofInPackedField.BOOL: Should have failed to parse, but didn't. request=protobuf_payload: "\332\002\001" requested_output_format: PROTOBUF message_type: "protobuf_test_messages.proto3.TestAllTypesProto3" test_category: BINARY_TEST, response=protobuf_payload: "\330\002\001"
ERROR, test=Required.Proto2.ProtobufInput.PrematureEofInPackedField.BOOL: Should have failed to parse, but didn't. request=protobuf_payload: "\332\002\001" requested_output_format: PROTOBUF message_type: "protobuf_test_messages.proto2.TestAllTypesProto2" test_category: BINARY_TEST, response=protobuf_payload: "\330\002\001"

These tests failed.  If they can't be fixed right now, you can add them to the failure list so the overall suite can succeed.  Add them to the failure list by running:
./update_failure_list.py  --add failing_tests.txt

Required.Proto2.ProtobufInput.PrematureEofInPackedField.BOOL
Required.Proto3.ProtobufInput.PrematureEofInPackedField.BOOL

CONFORMANCE SUITE FAILED: 386 successes, 443 skipped, 0 expected failures, 2 unexpected failures.

CONFORMANCE TEST BEGIN ====================================

ERROR, test=Required.Proto3.ProtobufInput.PrematureEofInPackedField.BOOL: Should have failed to parse, but didn't. request=protobuf_payload: "\332\002\001" requested_output_format: PROTOBUF message_type: "protobuf_test_messages.proto3.TestAllTypesProto3" test_category: BINARY_TEST, response=protobuf_payload: "\330\002\001"
ERROR, test=Required.Proto2.ProtobufInput.PrematureEofInPackedField.BOOL: Should have failed to parse, but didn't. request=protobuf_payload: "\332\002\001" requested_output_format: PROTOBUF message_type: "protobuf_test_messages.proto2.TestAllTypesProto2" test_category: BINARY_TEST, response=protobuf_payload: "\330\002\001"

These tests failed.  If they can't be fixed right now, you can add them to the failure list so the overall suite can succeed.  Add them to the failure list by running:
./update_failure_list.py /home/cretz/work/gojvm/pb-and-k/conformance/conformance-js/failing_tests.txt --add failing_tests.txt

Required.Proto2.ProtobufInput.PrematureEofInPackedField.BOOL
Required.Proto3.ProtobufInput.PrematureEofInPackedField.BOOL

CONFORMANCE SUITE FAILED: 378 successes, 443 skipped, 8 expected failures, 2 unexpected failures.

Which means it fails in Java and JS for both proto2 and proto3.

phcoder commented 5 years ago

I looked at it and it seems to me to be a problem in the test rather than in the code

phcoder commented 5 years ago

https://github.com/cretz/pb-and-k/pull/16