search

cretz / pb-and-k

Kotlin Code Generator and Runtime for Protocol Buffers
MIT License
139 stars 15 forks source link

Build an artifact compatible with the protobuf gradle plugin #19

Closed garyp closed 4 years ago

garyp commented 5 years ago

This ended up being quicker to implement than I thought. Fixes #18.

Globegitter commented 4 years ago

@cretz any chance to get this included?

cretz commented 4 years ago

Hrmm, @garyp and @Globegitter - are there any unintended side effects of anyone else using this library by using the spring framework boot plugin? Does it effect the final JAR or the project in anyway wrt dependencies?

I don't really work on this project much anymore, so I can blindly accept the merge if there are no unintended consequences, but can't really promise I'll publish a versioned release any time soon.

garyp commented 4 years ago

Hi @cretz. Sorry, just catching up after vacation. I don't believe this change will impact anyone using this library. It adds an additional JAR artifact (with the jvm8 classifier), but does not change the default JAR artifact that is produced, nor the POM file.

Regarding the project's maintenance, we're starting to use pb-and-k at my company and we have an actively maintained fork: https://github.com/streem/pbandk. We've fixed some bugs, added some ease-of-use improvements to the generated code, and have started on proto3 JSON support. If you're interested, we'd be glad to take over maintenance of pb-and-k.

cretz commented 4 years ago

If you're interested, we'd be glad to take over maintenance of pb-and-k.

@garyp - I would love to link to that maintained fork (I'd rather it stay over there instead of y'all having to maintain it under my GH name/org). I can't really work on this repo, so it'd be ideal if yours became the go-to. I even gladly give my blessing for y'all to change the package name, readme, copyright, remove the forked-from link, etc if y'all want to. Just let me know if that sounds ok, then I'll update this README with a notice pointing to y'all's repo.

garyp commented 4 years ago

@cretz If you wanted to update the README to point at https://github.com/streem/pbandk (note that our repo is lacking the dashes in the name), that'd be great. Thanks.

cretz commented 4 years ago

@garyp - Done! Thanks!