Include gradle 4.7 - Githubissues

cretz / pb-and-k

Kotlin Code Generator and Runtime for Protocol Buffers

MIT License

139 stars 15 forks source link

Include gradle 4.7 #5

Closed platoblm closed 6 years ago

cretz commented 6 years ago

I am not wanting to commit the gradle wrapper by intention. Rather, asking someone to use their own Gradle install should be enough. I personally disagree w/ Gradle best practices. Or are there reasons other than convenience? I understand working on the project requires manually downloading Gradle 4.7 (due to certain Kotlin plugin issues), but I accept that at least until the bug is fixed.

platoblm commented 6 years ago

Sorry created the PR by mistake as I wanted to merge my changes on my fork only. I'll close it. Yes, that was for my convenience - committing the gradle version and wrapper might make it easier to move between projects/commits that use different gradle versions. Nice work by the way.