search

crew102 / wosr

R clients to the Web of Science and Incites APIs
https://crew102.github.io/wosr/
Other
30 stars 8 forks source link

Possible to extract CNCI? #21

Open tarensanders opened 2 years ago

tarensanders commented 2 years ago

Hi there,

I'm wondering if it's possible to extract the CNCI values from the incites data, as documented here. It seems that pull_incites returns a value for "NCI" but I think this is the JNCI?

I'm happy to have a stab at this. I'm guessing that maybe this line is 'squashing' the returned list? https://github.com/vt-arc/wosr/blob/2a0947ce0b3153f88a8a04665112b17a822b0e14/R/pull-incites.R#L111

tarensanders commented 2 years ago

OK, pretty sure I've worked this out. The version that's documented on the website is version 2. To access version 2, you need to append "&ver=2" to the url. Basically, if I changed this line: https://github.com/vt-arc/wosr/blob/2a0947ce0b3153f88a8a04665112b17a822b0e14/R/pull-incites.R#L104

to 

response <- httr::GET(paste0(url, "&ver=2", collapse = ""), ua(), httr::add_headers(c("X-APIKey" = key)))

I get the updated output.

Unfortunately, I think this would be a breaking change, in that process_incites would also need to be updated, and the returned data is going to be different to what legacy code expects.

I really need this data, so I'm happy to open a branch to make these changes and then open a PR. But, if you don't want to support this, I'm also just happy to create a fork and do this separately. Let me know your preference.

crew102 commented 2 years ago

Hey @tarensanders , I'd be happy to review a PR if you're up for it. Problem is that I lost access to the WOS and InCites APIs about 3 years ago, so I haven't been able to test any changes to this package (or really confirm that it's still working at all). If you have an API key that you're able to use to query incites, and if you're able to run tests locally that confirm that tests pass, that would be enough for me to say go ahead and open up a PR.

tarensanders commented 2 years ago

Hi @crew102, good to know. After a bit more digging I was able to confirm that the NCI is actually the CNCI and not the JNCI. That was my main motivation, but there are a couple of other things in the new version that might be useful in the future. I'll put this on my backlog, but probably won't get to it anytime soon.