search

crewAIInc / crewAI

Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.
https://crewai.com
MIT License
20.08k stars 2.77k forks source link

[BUG]CrewAI0.6 Memory module failed and was not called at all #1388

Open fanhomi opened 1 week ago

fanhomi commented 1 week ago

Description

At CrewAI The src\crewai\agents\executor.py file of version 0.55.2 has calls to _create_short_term_memory and _create_long_term_memory from the CrewAgentExecutorMixin . In the latest version of the agents\agent_builder\base_agent_executor_mixin.py file, there are no calls to the above two functions, resulting in running a store with no long or short term memory.

Steps to Reproduce

None

Expected behavior

fix it

Screenshots/Code snippets

None

Operating System

Windows 10

Python Version

3.11

crewAI Version

0.6

crewAI Tools Version

0.12.1

Virtual Environment

Venv

Evidence

None

Possible Solution

None

Additional context

None

cburnicki commented 1 week ago

I have the same issue, it looks like the code has been unintentionally (?) removed during a refactoring by @joaomdmoura in commit e77442c.

I will prepare a PR.

cburnicki commented 5 days ago

I have a branch here, but tests are still broken and new tests are missing. I'll probably not be able to continue working on this before next week. Branch: issue-1388-restore-create-memory-call