Open andershagbard opened 1 year ago
@creyD What would be the ETA on having this bug resolved. My dev team's project uses your action as part of our build checks
@karkir0003 Can you please try with version 4.3?
It seems like using version 4.3 works @creyD. I'll keep you posted if another error comes up
Good, @andershagbard Please confirm that it works with 4.3 for you too.
Same error Cannot find module 'prettier-plugin-tailwindcss'
Feels like the problem is this: https://github.com/creyD/prettier_action/blob/31355f8eef017f8aeba2e0bc09d8502b13dbbad1/entrypoint.sh#L62-L65
Feels like the problem is this:
@timsu92 I don't think that's the issue. "prettier-plugin-tailwindcss"
matches that regex, and that's not the error message being presented anyway.
I'm seeing the same issue with v4.3: 'Cannot find module 'prettier-plugin-organize-imports'
.
name: Prettier
on:
push:
branches: [main]
pull_request:
branches: [main]
jobs:
prettier:
name: Prettier
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Prettify code
uses: creyD/prettier_action@v4.3
with:
dry: true
prettier_options: --check *.{mj,t}s examples/**/* packages/*/src/** packages/*/dev/** packages/react-querybuilder/genericTests/** website/*.js website/{docs,src,versioned_docs,versioned_sidebars}/**
prettier_plugins: 'prettier-plugin-organize-imports'
- name: Git diff
if: ${{ failure() }}
run: git diff && exit 1
@jakeboone02 Any ideas on how to fix this?
@creyD I'm not sure if this will help, but I had a similar issue when trying to use Prettier's JavaScript API from Bun. The solution to that particular problem was to specify the location of the /node_modules
directory with the pluginSearchDirs
option (--plugin-search-dir
on the command line). Seemed unnecessary but, like I said, it resolved the issue.
I was having this same issue with prettier_action v4.3
(and the config files shown below) and was able to work around it by adding an npm install
step before calling the action to install the plugin to the runner rather than relying on the action to do it which seems to get it to work -- not sure if that helps with debugging this or helps anyone else work around it?
Here's my (now) working workflow file for reference
...
jobs:
build-and-test:
name: 'Build, Format and Test'
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: NPM Install
run: npm i
- name: Run Prettier
if: ${{ github.ref != 'refs/heads/main' }}
uses: creyD/prettier_action@master
with:
prettier_options: --write {**/*,*}.{js,jsx,mjs,cjs,ts,tsx,css,scss,sass}
file_pattern: "src"
prettier_plugins: "prettier-plugin-tailwindcss"
...
my .prettierrc.js
/** @type {import("prettier").Options} */
module.exports = {
trailingComma: 'es5',
tabWidth: 2,
semi: true,
singleQuote: true,
jsxSingleQuote: true,
plugins: ['prettier-plugin-tailwindcss'],
};
and my devDependencies
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/parser": "^5.62.0",
"eslint": "^8.47.0",
"eslint-plugin-jest-dom": "^5.0.2",
"eslint-plugin-react": "^7.33.2",
"prettier": "^3.0.2",
"prettier-plugin-tailwindcss": "^0.5.3",
"tailwindcss": "^3.3.3"
},
I can confirm
npm install prettier prettier-plugin-java --save-dev
works.
The following workflow gives this error:
Workflow
.prettierrc.json
Not sure how to proceed.