search

creyD / prettier_action

GitHub action for running prettier on your projects pull requests
MIT License
276 stars 87 forks source link

IDEA: Add push_options parameter #120

Open chicco785 opened 1 year ago

chicco785 commented 1 year ago

push_options are not set as environmental variables, due to that, they cannot be passed to the shell script

https://github.com/creyD/prettier_action/blob/9561a3f1e164fa28b6f4da59c1807e1cd1af7cf5/action.yml#L70-L83

koppor commented 11 months ago

Maybe, the feature https://github.com/creyD/prettier_action/issues/80 is a work-around for that. Having proper git pushes is a hard task - and maybe, another action should be used (and this action can focus on nice running of prettier)

chicco785 commented 11 months ago

@koppor in dev I think this is now tackled :)

chicco785 commented 11 months ago

see: https://github.com/creyD/prettier_action/pull/123