Open rwrj opened 1 year ago
Getting similar issue here, v.4.3.
Run creyD/prettier_action@v4.3 Run PATH=$GITHUB_ACTION_PATH/node_modules/.bin:$PATH /home/runner/work/_actions/creyD/prettier_action/v4.3/entrypoint.sh Installing prettier... Checking plugin: @prettier/plugin-php Error: Process completed with exit code 1.
This is caused by breaking changes in prettier v3. Use the prettier_version
option to pin the prettier version to 2.x.x.
This is caused by breaking changes in prettier v3. Use the
prettier_version
option to pin the prettier version to 2.x.x.
Thanks! It works with Prettier 2.8.8, which was the last version before 3.0. Do you think this is an issue with prettier or the prettier-php plugin? I can try raising the issue at the appropriate place.
Run prettier v3 on your own source files first before looking to raise an issue elsewhere.
Pinning prettier at version 2.8.8 has solved my issues, which looked like this when prettyfying solidity:
Error: No parser could be inferred for file "[...]".
This worked for a while but now I'm getting the same error again even after pinning Prettier to version 2.8.
Does anyone have any workarounds or suggestions for fixing this?
@rwrj If your prettier plugins have been updated to support Prettier v3+, then you either have to pin them too, or unpin Prettier. In the end, make sure you know exactly which versions of Prettier and your plugins are running on this Github workflow and using those versions replicate the issue on your localhost. Then you'll know what to do.
@igitur Yes, it's possible that the PHP plugin has been updated. I tried unpinning Prettier but that didn't work either. How can I pin the version of prettier/plugin-php to 0.19.7? This seems to be the last version working with prettier 2.x - https://github.com/prettier/plugin-php/releases/tag/v0.19.7
I'm sorry if this is a silly question but I can't figure out how to set the version of the plugin in the workflow config.
I've tried running this on my localhost and seem to be getting the same error but I'm not sure if I'm doing something else wrong there - I haven't worked much with node / npm before.
@rwrj Specify the plugin npm package in this format: example-package@1.2.3
. To be honest, if you haven't used node / npm much before, you should upskill yourself on that first. ChatGPT is a great help.
@igitur I got this set up and the Prettier PHP plugin is working fine on my local machine (Ubuntu 22.04 - which should be the same version being used in the GitHub Action) It's running Prettier v3.0.3 ChatGPT was a great suggestion, I was struggling getting things to work from the Prettier docs.
Any suggestions on how to proceed from here? Could this possible be an issue with the version of node being run? I see this warning on the GitHub Actions page with the failed run:-
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Update: This error seems to be gone now when running on the latest version of Prettier, however it gives the error No parser could be inferred for file "/home/runner/work/.../*.php".
for each PHP file.
What exactly happened? Getting this error when running the action:
Error: Process completed with exit code 1.
This seems to be happening when initializing the prettier-php pluginWhat should've happened? Prettier should have run successfuly
How did it look? Here is the full log from the run:-
Where did you encounter the problem? When the action ran on making a push.
Here is my full configuration file for reference:-