creyD / prettier_action

GitHub action for running prettier on your projects pull requests
MIT License
276 stars 87 forks source link

[BUG] Should work when package-lock.json is not versioned #128

Open koppor opened 1 year ago

koppor commented 1 year ago

What exactly happened?

  1. Have a repository without package-lock.json
  2. Run action

What should've happened?

Everything working.

How did it look?

Deleting node_modules/ folder...
error: pathspec 'package-lock.json' did not match any file(s) known to git

Where did you encounter the problem?

Workarounds:

creyD commented 10 months ago

Could you please check if it works if you use @dev instead of the version you are using? If yes, I will merge it.

dmitvitalii commented 8 months ago

Same problem here.

@creyD , tried the @dev version:

Installing prettier...
Checking plugin: prettier-plugin-organize-imports
Prettifying files...
Files:
/home/runner/work/_actions/creyD/prettier_action/dev/entrypoint.sh: line 64: prettier: command not found
Error: Process completed with exit code 1.
bastien-snk commented 7 months ago

I have the same problem here. I tried with the dev version also and got the same problem as @dmitvitalii.

Muhammed-Rahif commented 4 days ago

I am using pnpmas package manager which also don't have a package-lock.json and ran into this problem.