search

crflynn / pypistats.org

PyPI downloads analytics dashboard
https://pypistats.org/
138 stars 10 forks source link

Smooth trailing 7days, and smooth *before* calculating proportions #33

Closed Zac-HD closed 2 years ago

Zac-HD commented 3 years ago

Fixes #21 and closes #25 (with thanks to @scottgigante). The two differences to #25 are that

  1. Instead of centering the smoothing window, we use the trailing seven days. This means that the effect of the shorter window does not impact the most recent days of data, which is where maintainers tend to be most concerned - otherwise there would be a big dip on weekends when the window was Thurs-Sun and not yet brought back up by Mon-Tues.

  2. The proportional calculations have been refactored from "average of proportions" to "proportion of averages" - which is much less impacted by random variations, and the obvious interpretation when the plain averages are visible in the previous chart.

@crflynn - I'm keen to get this merged soon, is there anything I can do to help that?

scottgigante commented 3 years ago

Brilliant work, thanks @Zac-HD for taking my PR and making it better!

Zac-HD commented 3 years ago

@crflynn - anything I can do to help get this merged?

Zac-HD commented 2 years ago

@crflynn - ping, it's been a while but I'd still like to get this merged so that I can understand my download numbers. Anything I can do to help, or can you merge it as-is?

Zac-HD commented 2 years ago

Closing this just to get it off my stack of open PRs 😕

scottgigante commented 2 years ago

Sad :(