crflynn / skgrf

scikit-learn compatible Python bindings for grf (generalized random forests) C++ random forest library
https://skgrf.readthedocs.io/en/stable/
GNU General Public License v3.0
31 stars 7 forks source link

check_estimator tests #38

Closed crflynn closed 3 years ago

crflynn commented 3 years ago

Add check_estimator tests. We can't test the survival, instrumental, or causal forests because they don't conform to sklearn's regressor conventions.

In doing so we add validation to ensure check_estimator passes. We also add logic to ensure that passing sample_weight of ones is equivalent to passing None.

Changes:

https://scikit-learn.org/stable/modules/generated/sklearn.utils.estimator_checks.check_estimator.html

Closes #31