search

crflynn / skranger

scikit-learn compatible Python bindings for ranger C++ random forest library
https://skranger.readthedocs.io/en/stable/
GNU General Public License v3.0
51 stars 7 forks source link

Bugfix for quantile regression #114

Closed corwinjoy closed 2 years ago

corwinjoy commented 2 years ago

Thanks for writing this great wrapper! I'd like to propose a minor bugfix. It turns out that quantile regression throws an exception when it tries to predict on one row. I have added a reshape call to fix this edge case.

crflynn commented 2 years ago

Failure here is unrelated to your changes. I'll fix it and get it merged later today.

corwinjoy commented 2 years ago

Awesome! I did also add a unit test for this edge case so hopefully that will keep this issue from coming back as well.