search

crhume / pwm

Automatically exported from code.google.com/p/pwm
0 stars 0 forks source link

Add SMS support #56

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
* Request password reset, forgotten username --> only email token available
* This ticket is for reference and discussion, I'll post code updates later

What is the expected output? What do you see instead?
* Expected: Token via SMS
* Observed: only email available

Please use labels and text to provide additional information.

As promised before, I'm working on SMS support. With my code changes, I'm able 
to send an SMS. The code should be suitable for several different SMS services 
with HTTP(S) access.

What I've done so far:
* Extended the settings with SMS specific settings and advanced HTTP proxy 
settings
* Added an SmsItemBean and SmsQueueManager
* Added the queue to the context manager
* Added a constant MAX_SMS_QUEUE_SIZE=100
* Added an SMS_QUEUE to the pwmDB.

To be done:
* Support for long messages (split)
* Proxy support for the queue manager
* Preference sms vs email
* Integration into the application:
  * New User
  * New Guest
  * Forgotten Password
  * Forgotten User Name

I expect to finish code changes within the next week.

Original issue reported on code.google.com by menno.pi...@gmail.com on 11 Apr 2011 at 7:34

GoogleCodeExporter commented 9 years ago 
Looks great, keep it coming!   I'm currently working through the guest account 
patch..

Original comment by jrivard on 13 Apr 2011 at 2:16

GoogleCodeExporter commented 9 years ago 
Patches and new files.

Finished:
* Support for long messages (split)
* Proxy support for the queue manager
* Preference sms vs email
* Integration into the application:
  * Forgotten Password

To be done:
* Integration into the application:
  * New User
  * New Guest
  [will wait until Guest patch is accepted]

Cancelled:
* Integration into the application:
  * Forgotten User Name
  [Noticed it is different from Forgotten Password, does not send email]

Future:
* Send admin notification for certain events?
* Send password change notification?
...?

Original comment by menno.pi...@gmail.com on 13 Apr 2011 at 8:51

Attachments:

GoogleCodeExporter commented 9 years ago 
Forgot to add a patch for the ContextManager

Original comment by menno.pi...@gmail.com on 15 Apr 2011 at 11:21

Attachments:

GoogleCodeExporter commented 9 years ago 
Updates some diffs (thans to Alessando for testing):

* Added an option for encoding/escaping of SMS data;
* Now correctly showing destination(s) for token on password recovery

Original comment by menno.pi...@gmail.com on 18 Apr 2011 at 8:36

Attachments:

GoogleCodeExporter commented 9 years ago 
Additional changes tot the SmsQueueManager

Original comment by menno.pi...@gmail.com on 19 Apr 2011 at 1:02

Attachments:

GoogleCodeExporter commented 9 years ago 
Can you please share a full copy of PwmSettings.properties?  The diff seems to 
be missing some settings.

Original comment by jrivard on 23 Apr 2011 at 3:30

GoogleCodeExporter commented 9 years ago 
Of course....

Original comment by menno.pi...@gmail.com on 23 Apr 2011 at 9:24

Attachments:

GoogleCodeExporter commented 9 years ago 
Patched into revision 139.  Looks nice.  What service can I use to test this?

Original comment by jrivard on 24 Apr 2011 at 1:26

GoogleCodeExporter commented 9 years ago 
I've used it with ClickATell (POST or GET; example in dev. documentation).
Alessando Canovi reported that has used it with an in-house developed
gateway (SOAP based, example based on this one added to documentation). It
should be usable with almost any HTTP/HTTPS based SMS service, as long as
the message can be sent in one request and requires no exotic authentication
tricks.

Original comment by menno.pi...@gmail.com on 24 Apr 2011 at 7:05

GoogleCodeExporter commented 9 years ago 
One more thing needs to be added: extra HTTP headers, for example SOAPAction to 
use in SOAP request.
I'm working on that.

Original comment by menno.pi...@gmail.com on 3 May 2011 at 8:43

GoogleCodeExporter commented 9 years ago 
Closing this issue as SMS integration appears to be complete.  Open a new issue 
if needed for new features/bugs.

Original comment by jrivard on 21 May 2011 at 10:39