runcom
commented
7 years ago /cc @mtrmac as well, c/image is currently broken by k8s right now
Closed mzylowski closed 7 years ago
runcom
commented
7 years ago /cc @mtrmac as well, c/image is currently broken by k8s right now
mtrmac
commented
7 years ago I can’t immediately see why your vending mechanism is removing things like vendor/github.com/containers/image/copy/copy.go; as long as they have direct uses in cri-o, they should continue to be included?!
As for the k8s.io failures, that is fixed in https://github.com/containers/image/pull/223 . Perhaps we should just merge that, test failures or not, so that consumers of containers/image have a chance of it working?
(Or, perhaps, cri-o could not bump k8s for a while until containers/image settles down. Hopefully that does happen soon, right now we average about one upstream breaking containers/image every two days…)
runcom
commented
7 years ago For the record containers/image vendoring should be fixed now. If you guys could retry that would be great.
runcom
commented
7 years ago testing this right now, I can see the vendoring script is removing lots of stuff (bumping containers/image to latest master) :confused:
runcom
commented
7 years ago @mrunalp @cyphar @jawnsy could you also chime in here?
jawnsy
commented
7 years ago Whoops, I think this is my fault, more fallout due to #320. Please assign this to me.
I didn't realize that our vendor script tries to use vendor/ as a GOPATH, but this no longer works because my change removes src and moves everything to the top-level vendor directory.
This is visible if you add set -x to vendor.sh:
+ dirname hack/vendor.sh
+ cd hack/..
+ source hack/.vendor-helpers.sh
+ PROJECT=github.com/kubernetes-incubator/cri-o
+ mkdir -p vendor
+ original_GOPATH=/home/jawnsy/projects/cri-o/
+ export GOPATH=/home/jawnsy/projects/cri-o/src/github.com/kubernetes-incubator/cri-o/vendor:/home/jawnsy/projects/cri-o/
+ GOPATH=/home/jawnsy/projects/cri-o/src/github.com/kubernetes-incubator/cri-o/vendor:/home/jawnsy/projects/cri-o/
+ find=/usr/bin/find
+ case $# in
+ rm -rf vendor/
mrunalp
commented
7 years ago @mzylowski Could you take a look at #352?
I'm stuck trying to bump some packages in cri-o repo.
For current master (89e4c549950f9fc9bd50d919a88cd7c6b4889f1f)
Reproduction: Getting custom k8s commit:
git status after command:
make cmd results:
So let's try update containers/image dependency: Cmd:
Git status
So... A lot of files are deleted make cmd results:
I also tried to revendor everything, but also a lot of required packages was removed.
cc @runcom @jjlakis