search

cri-o / cri-o

Open Container Initiative-based implementation of Kubernetes Container Runtime Interface
https://cri-o.io
Apache License 2.0
5.07k stars 1.05k forks source link

[release-1.25] Kill exec PIDs after main container exited #8177

Closed openshift-cherrypick-robot closed 1 month ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #8162

/assign kwilczynski

Fixed pod lifecycle regression where the exec PID's got killed before the actual container.
kwilczynski commented 1 month ago

/approve /lgtm

kwilczynski commented 1 month ago

@cri-o/cri-o-maintainers, this will require an override. Thank you!

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cri-o/cri-o/blob/release-1.25/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment