search

cri-o / cri-o

Open Container Initiative-based implementation of Kubernetes Container Runtime Interface
https://cri-o.io
Apache License 2.0
5.24k stars 1.06k forks source link

Fix `typos` in CI #8740

Closed saschagrunert closed 2 weeks ago

saschagrunert commented 2 weeks ago

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

While it's actually not a typo, the var sserver does not really indicate what it's meant to be. We rename it to become a more verbose streamingServer to fixup both issues.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.44%. Comparing base (258db15) to head (87d6b60). Report is 13 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8740 +/- ## ======================================= Coverage 46.44% 46.44% ======================================= Files 150 150 Lines 21962 21962 ======================================= Hits 10201 10201 Misses 10693 10693 Partials 1068 1068 ```
saschagrunert commented 2 weeks ago

@cri-o/cri-o-maintainers PTAL

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/cri-o/cri-o/blob/main/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
saschagrunert commented 2 weeks ago

/override ci/prow/e2e-gcp-ovn

openshift-ci[bot] commented 2 weeks ago

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp-ovn

In response to [this](https://github.com/cri-o/cri-o/pull/8740#issuecomment-2458952300): >/override ci/prow/e2e-gcp-ovn Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.